Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize and modlarize tests in t/primitive.t #453

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Reorganize and modlarize tests in t/primitive.t #453

merged 4 commits into from
Sep 13, 2023

Conversation

djerius
Copy link
Contributor

@djerius djerius commented Aug 23, 2023

This commit reorganizes and modularizes t/primitive.t, moving related tests into separate files.
It switches over to Test2::V0.

Splitting the large monolithic t/primitive.t into smaller chunks will speed up tests if parallel testing (e.g. prove -j or yath -j) harnesses are used.

@coveralls
Copy link

Coverage Status

coverage: 28.892% (-0.02%) from 28.909% when pulling 30b43e2 on rehab_primitive-tests into 4f12de9 on master.

@djerius djerius requested a review from mohawk2 August 24, 2023 21:41
zmughal
zmughal approved these changes Aug 26, 2023
View reviewed changes
Copy link
Member

@zmughal zmughal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. And clean!

While it does add a dependency on Test2::V0, I believe that it is widely used enough to justify using it (I use it myself). Plus modern Test-Simple uses Test2 anyway.

@djerius
Copy link
Contributor Author

djerius commented Sep 13, 2023

Looks good to me. And clean!

While it does add a dependency on Test2::V0, I believe that it is widely used enough to justify using it (I use it myself). Plus modern Test-Simple uses Test2 anyway.

Thanks for the review.

@djerius djerius merged commit 457ff25 into master Sep 13, 2023
@djerius djerius deleted the rehab_primitive-tests branch September 13, 2023 19:27
@zmughal
Copy link
Member

zmughal commented Nov 20, 2023

Just to add this this, Test2::V0 will be a dual life module in Perl 5's core in the next release Perl/perl5#21481, perl5394delta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmughal zmughal zmughal approved these changes

@mohawk2 mohawk2 Awaiting requested review from mohawk2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djerius @coveralls @zmughal